[#190] Make chapter title required on chain page#226
Conversation
- Title field no longer marked optional — label updated - Submit button disabled when title is empty - Validation message shown when content is entered but title is blank Fixes #190 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b: APPROVE
Clean change: title made required with trim() validation, submit button disabled when empty, error message shown contextually (only when content has been entered). Character counter preserved.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The required-title behavior is correctly wired, but the PR still misses two explicit UI details from issue #190. Since this ticket is narrowly scoped to the field contract, those details should match the spec exactly.
Findings
- [medium] Chapter-title placeholder does not match the issue copy
- File:
src/app/chain/page.tsx:151 - Suggestion: use the requested placeholder text
e.g. The Silent Storminstead ofe.g. The Awakeningso the field matches the issue spec.
- File:
- [medium] Character counter format does not match the issue copy
- File:
src/app/chain/page.tsx:161 - Suggestion: render the counter in the requested
42 / 100 charsstyle. The current output is${title.length}/100, which omits the spaces andcharssuffix called for in #190.
- File:
Decision
Requesting changes because #190 gives explicit field-copy acceptance criteria, and the current UI still diverges from those details.
- Placeholder: "e.g. The Silent Storm" - Counter: "42 / 100 chars" format Addresses T2a review feedback on PR #226. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up change brings the remaining field copy into line with issue #190: the placeholder now uses the requested example text and the counter now renders in the specified 42 / 100 chars format. The required-title behavior remains intact, and the updated head passes GitHub lint-and-typecheck.
Findings
- None.
Decision
Approving because the previously flagged copy mismatches are resolved and the chain-page title field now matches the issue spec.
2 participants
Summary
Test plan
Fixes #190
🤖 Generated with Claude Code